-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI changes for DAG Reparsing feature #39636
Conversation
The icon might be misleading. It may be confused with refresh page |
@raphaelauv To me, this looks like searching a file, but I'm not sure what would be better. |
@utkarsharma2 yes you are right then this ? |
Let's try it and see if it's not too detailed for the size we display it at. |
I'm not able to find this icon in airflow's supported lib - https://materializecss.com/icons.html. |
Looks great to me! Do the Dags list and dag details pages refresh once the DAG is reparsed? |
Yes, the redirect URL part handles it, right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
* UI changes for DAG Reparsing feature releated: apache#39138 * Add correct permission for UI * Fix JS * Update airflow/www/static/js/main.js * Add a wrapper arounf REST DAG Reparsing API * Move file_token from dag object to a separate field * Fix CI issue * Change icons
This PR introduces the UI changes required to consume the DAG Reparsing API.
Home page
Detail page
related: #39138