Add timeout when watching pod events in k8s executor #39551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
jedcunningham
approved these changes
May 10, 2024
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
RNHTTR
approved these changes
May 10, 2024
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
dirrao
reviewed
May 11, 2024
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
If we don't set a timeout, it may hang indefinitely if there's a network issue.
…r_utils.py Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
dstandish
force-pushed
the
add-timeout-when-reading-pod-events
branch
from
654739b to
54a3fe0
Compare
eladkal
approved these changes
May 14, 2024
Contributor
|
Should this be marked as closes #36998 ? |
Contributor
Author
it's not obvious to me how this would be connected to that issue |
RNHTTR
approved these changes
May 14, 2024
This was referenced May 26, 2024
This was referenced Jun 7, 2024
brumi1024
reviewed
Jul 5, 2024
Comment on lines
+156
to
+157
| kwargs["_request_timeout"] = client_timeout | ||
| kwargs["timeout_seconds"] = server_conn_timeout |
Member
There was a problem hiding this comment.
These settings were configurable using the AIRFLOW__KUBERNETES_EXECUTOR__KUBE_CLIENT_REQUEST_ARGS env variable, but now they are overridden if I'm not mistaken. Is this expected?
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
If we don't set a timeout, it may hang indefinitely if there's a network issue. --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't set a timeout, it may hang indefinitely if there's a network issue.