Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upload_files_v2 Slack SDK method by default in Slack Operators #39340

Merged

Conversation

Taragolis
Copy link
Contributor

Couple days ago Slack sent auto message to my my email which informed me that files.upload discontinued soon

Hello Andrey Anshin,

A workspace that you administer contains apps or integrations that recently used the files.upload web API method. We want to inform you about two important changes coming to support for the files.upload API.

May 8, 2024
Newly created Slack apps will no longer be able to access the files.upload API. Existing applications will be able to continue using files.upload until support is discontinued.

March 11, 2025
Support for the files.upload API for all apps will be discontinued.

Link for more details about upcoming changes: https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay

Recently we add support of v2 method #36757, and also add SlackHook.send_file_v1_to_v2 for smooth transition between v1 and v2 which used in operators under the hood

So I would propose to switch by default to v2:

  • Users who create Slack Apps after the May 8, 2024 has not affected and could use Slack Operators which intends to send files into the slack
  • Users who use Slack Apps which created before May 8, 2024 should grant additional scopes for the application, no mandatory changes required in existed tasks

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis requested a review from eladkal as a code owner May 1, 2024 09:17
@Taragolis Taragolis changed the title Use upload_files_v2 Slack SDK method by default in Slack Operators Use upload_files_v2 Slack SDK method by default in Slack Operators May 1, 2024
@Taragolis Taragolis force-pushed the use-slack-upload-files-v2-by-default branch from 07e8973 to cc25d71 Compare May 1, 2024 09:23
@Taragolis Taragolis force-pushed the use-slack-upload-files-v2-by-default branch from cc25d71 to 7d6b804 Compare May 1, 2024 09:28
@eladkal eladkal merged commit 7a0fa64 into apache:main May 1, 2024
40 checks passed
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, looks good +1

RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants