Allow trust env parameter to be defined in extra options of HTTP Connection #39161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld of HTTP Connection
dirrao
suggested changes
Apr 22, 2024
Yes this is when you want the requests library to ignore the environment variables. In our case we have default proxy environment variables defined, but in some cases we need to pass through another proxy, so even if we specify the proxy parameter, the request library will still use the one from the env variable unless we tell it to ignore it. |
dabla
changed the title
|
Is it possible to merge this PR as this also impacts this PR so I can fix the merge conflicts on the later one and continue working on it? Thanks :) |
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…ection (apache#39161) * refactor: Allow trust env parameter to be defined in extra options field of HTTP Connection * refactor: Added missing comma * refactor: Added special case when trust_env set to False --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR which also allows trust env to be defined in the extra options of the Connection
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.