Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch AzureDataLakeStorageV2Hook to use ManagedIdentityCredential for managed identity/workload auth #38497

Merged
merged 6 commits into from
May 27, 2024
Merged

Switch AzureDataLakeStorageV2Hook to use ManagedIdentityCredential for managed identity/workload auth #38497

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
992e4ab
switch AzureDataLakeStorageV2Hook to ManagedIdentityCredential for wo…
TJaniF Mar 26, 2024
694b279
Merge branch 'main' into fix_adls_hook_workload_id_credentials
TJaniF May 16, 2024
74439cc
use get_sync_default_azure_credential instead of ManagedIdentityCrede…
TJaniF May 16, 2024
5ced7c2
add test_get_conn_with_workload_identity
TJaniF May 16, 2024
2acd419
Merge branch 'main' into fix_adls_hook_workload_id_credentials
TJaniF May 16, 2024
839c6d8
Merge branch 'main' into fix_adls_hook_workload_id_credentials
TJaniF May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions airflow/providers/microsoft/azure/hooks/data_lake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from azure.core.exceptions import ResourceExistsError, ResourceNotFoundError
from azure.datalake.store import core, lib, multithread
from azure.identity import ClientSecretCredential
from azure.identity import ClientSecretCredential, ManagedIdentityCredential
from azure.storage.filedatalake import (
DataLakeDirectoryClient,
DataLakeFileClient,
Expand All @@ -40,7 +40,7 @@
get_field,
)

Credentials = Union[ClientSecretCredential, AzureIdentityCredentialAdapter]
Credentials = Union[ClientSecretCredential, AzureIdentityCredentialAdapter, ManagedIdentityCredential]


class AzureDataLakeHook(BaseHook):
Expand Down Expand Up @@ -357,10 +357,10 @@ def get_conn(self) -> DataLakeServiceClient: # type: ignore[override]
credential = conn.password
else:
managed_identity_client_id = self._get_field(extra, "managed_identity_client_id")
workload_identity_tenant_id = self._get_field(extra, "workload_identity_tenant_id")
credential = AzureIdentityCredentialAdapter(
managed_identity_client_id=managed_identity_client_id,
workload_identity_tenant_id=workload_identity_tenant_id,
credential = (
Lee-W marked this conversation as resolved.
Show resolved Hide resolved
ManagedIdentityCredential(client_id=managed_identity_client_id)
if managed_identity_client_id
else ManagedIdentityCredential()
)

account_url = extra.pop("account_url", f"https://{conn.host}.dfs.core.windows.net")
Expand Down