Remove D105 from pyproject.toml #38452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The D105 ("require documenting of magic methods") does not bring
too much value and leads to bogus comments. As discussed in
the https://lists.apache.org/thread/8jbg1dd2lr2cfydtqbjxsd6pb6q2wkc3
we universally agree that the rule should not be enabled.
Lee-W
approved these changes
Mar 25, 2024
This was referenced Mar 25, 2024
aritra24
approved these changes
Mar 25, 2024
ephraimbuddy
approved these changes
Mar 25, 2024
eladkal
approved these changes
Mar 25, 2024
hussein-awala
approved these changes
Mar 25, 2024
77 tasks
ephraimbuddy
added
the
changelog:skip
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The D105 ("require documenting of magic methods") does not bring too much value and leads to bogus comments. As discussed in the https://lists.apache.org/thread/8jbg1dd2lr2cfydtqbjxsd6pb6q2wkc3 we universally agree that the rule should not be enabled.
closes: #37523
related: #10742
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.