Fix parent_model parameter in GCP Vertex AI AutoML and Custom Job operators
#38417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
shahar1
force-pushed
the
fix-automl-parent-model-parsing
branch
from
cd102bb to
c249af4
Compare
shahar1
force-pushed
the
fix-automl-parent-model-parsing
branch
from
c249af4 to
108318c
Compare
eladkal
approved these changes
Mar 23, 2024
This was referenced May 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37400
The following line wrongly parsed the
parent_modelparam in all Vertex AI AutoML "Create" operators:The
parent_modelshould be either the actualy ID (integer) or the its resource name format (e.g.,projects/my-project/location/my-location/models/parent_model_id). After removing the line, it seems to work fine (I checked it).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.