NeptuneStopDbClusterOperator - Handle invalid cluster states #38287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
Author
|
@ferruzzi This is the PR for the neptune operators. |
Taragolis
reviewed
Mar 19, 2024
o-nikolas
reviewed
Mar 20, 2024
syedahsn
reviewed
Mar 20, 2024
Contributor
|
@ellisms is the PR ready for re-review? |
Contributor
Author
|
@eladkal Not yet, just getting back into the office. Working on making the suggested changes. |
Contributor
Author
|
This is ready for re-review. |
vincbeck
reviewed
Apr 16, 2024
eladkal
reviewed
May 21, 2024
ferruzzi
approved these changes
May 21, 2024
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left a couple nitpicks, but nothing blocking. Feel free to resolve them if you disagree with any of them.
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
eladkal
approved these changes
May 22, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…apache#38287) * Cache s3 resource to reduce memory usage * Fixed missing rebase changes and error in resource init * catch invalid state exceptions and wait if not terminal status * PR changes * Update airflow/providers/amazon/aws/triggers/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * PR review changes. Created helper function to deal with waitable ClientErrors * added missing exception code * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * fix static checks * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * minor PR changes --------- Co-authored-by: Niko Oliveira <onikolas@amazon.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38120
Handles case where the stop cluster api returns either InvalidClusterState or InvalidDBInstanceState exceptions. The operator now uses the waiter to wait for the cluster to be available. Also updated the start cluster operator to do the same.