ECS Executor - add support to adopt orphaned tasks. #37786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruzzi
requested review from
XD-DENG,
ashb,
eladkal,
hussein-awala,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:Executors-core
ferruzzi
commented
Feb 29, 2024
ferruzzi
commented
Feb 29, 2024
ferruzzi
commented
Feb 29, 2024
dirrao
reviewed
Feb 29, 2024
Contributor
Author
|
@eladkal - You had some comments in the previous attempt at this, you may want to have eyes on this one. |
o-nikolas
approved these changes
Feb 29, 2024
syedahsn
reviewed
Mar 4, 2024
syedahsn
reviewed
Mar 5, 2024
ferruzzi
force-pushed
the
ferruzzi/ecs-executor/adoption-agency
branch
3 times, most recently
from
98fe86b to
c390d07
Compare
ferruzzi
force-pushed
the
ferruzzi/ecs-executor/adoption-agency
branch
from
c390d07 to
ee6f7ba
Compare
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### Depends on and blocked by #37784<= mergedOnce the external_executor_id bug is fixed, this will add the feature to adopt abandoned tasks in the ECS Executor. To test, you can launch an ECS Executor environment and run a dag which takes a few minutes. While it is running, kill the scheduler. Before this change, when you restart the scheduler, the existing ECS job will be terminated and rescheduled/restarted. After this change, the running task will be adopted; it will finish and be monitored as if it was launched by this executor/scheduler instance.
Was previously #36803
closes: #35491
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.