openlineage: add opt-in option
#37725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:openlineage
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
242c9ef to
86d8b5e
Compare
mobuchowski
reviewed
Feb 27, 2024
uranusjr
reviewed
Feb 27, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
2 times, most recently
from
aa139e6 to
6472b9f
Compare
mobuchowski
reviewed
Mar 8, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
6472b9f to
fde66c9
Compare
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
fde66c9 to
bd81eef
Compare
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
bd81eef to
b5ba591
Compare
kacpermuda
reviewed
Mar 25, 2024
kacpermuda
reviewed
Mar 25, 2024
mobuchowski
approved these changes
Mar 25, 2024
Contributor
mobuchowski
left a comment
mobuchowski
left a comment
There was a problem hiding this comment.
LGTM, just address one @kacpermuda comment before merging.
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
b5ba591 to
e988501
Compare
uranusjr
reviewed
Mar 26, 2024
uranusjr
reviewed
Mar 26, 2024
by default and enable it selectively. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
e988501 to
1a5d79e
Compare
kacpermuda
reviewed
Mar 26, 2024
uranusjr
approved these changes
Mar 26, 2024
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
1a5d79e to
e0a08d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
Currently you can only disable OpenLineage for all DAGs and tasks or selectively disable by operator class. Users report lack of possibility to do so on DAG/task level instead while opting in.
Proposed solution
Add
opt_inoption as well asenable/disable_lineagemethods that work both on DAG and task objects.Internally it passes constant parameter (Airflow's
airflow.models.Param) that is next checked in OpenLineage listener.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.