Enhancing breeze commands with PACKAGE_LIST env variable #37502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
jedcunningham,
kaxil,
pierrejeambrun and
potiuk
as code owners
Contributor
Author
|
cc @eladkal added this support |
eladkal
reviewed
Feb 17, 2024
potiuk
force-pushed
the
enhanceBreezeCommandWithEnv
branch
from
8b1a7ea to
468bd2d
Compare
Contributor
Author
|
@eladkal can you take a look at this PR when you have some time? |
potiuk
reviewed
Feb 19, 2024
potiuk
reviewed
Feb 19, 2024
Contributor
Author
|
@potiuk handled the review comments. An example of the error case when both the environment variable as well as individual arguments are passed to the command. I am publishing a warning like so: |
Contributor
Author
|
Oops, image needed to see color coding |
Contributor
Author
Member
|
Yeah. And conflicts :) |
Contributor
Author
potiuk
approved these changes
Feb 22, 2024
sudiptob2
pushed a commit
to Satoshi-Sh/airflow
that referenced
this pull request
Feb 22, 2024
* Enhancing breeze commands with PACKAGE_LIST env variable * removing from add-back-references as it is idempotent * review comments from potiuk * fixing doc building * fixing static checks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 22, 2024
The apache#37502 added --package-list option to prepare-provider-packages and publish-docs release management command, but in cases packages were passed by arguments it actually generated empty list of packages and all packages were attempted to be created. Only those ready to be released were prepared, but all of them. This PR fixes it.
potiuk
added a commit
that referenced
this pull request
Feb 22, 2024
The #37502 added --package-list option to prepare-provider-packages and publish-docs release management command, but in cases packages were passed by arguments it actually generated empty list of packages and all packages were attempted to be created. Only those ready to be released were prepared, but all of them. This PR fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specifying the provider ID for each command we run during releasing providers, a variable is set, allowing for easy reuse throughout the process. This reduces redundancy and makes it easier when releasing subset of providers.
Defining the env:
Running prepare-provider-packages:
Running build-docs
Running publish-docs
Doesbnt make sense to add for
add-back-referencesas it is idempotent.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.