Allow pre-population of trigger form values via URL parameters #37497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:webserver
dirrao
requested changes
Feb 17, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Static checks are failing.
jscheffl
force-pushed
the
bugfix/32859-allow-pre-populate-form-fields-in-trigger-form
branch
from
82c6f20 to
ce46d8c
Compare
jscheffl
force-pushed
the
bugfix/32859-allow-pre-populate-form-fields-in-trigger-form
branch
from
ce46d8c to
be98590
Compare
bbovenzi
approved these changes
Feb 20, 2024
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
UI part makes sense to me. I'd appreciate someone to check the python code a bit more
potiuk
approved these changes
Feb 20, 2024
68 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Allow pre-population of trigger form values via URL parameters * Fix docs reference (cherry picked from commit 099925b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the (missing) option reported as Bug a while ago that the DAG trigger form can be called with default values populated.
How to test:
example_params_ui_tutorialand add URL parameters and see fields are pre-populated, e.g./dags/example_params_ui_tutorial/trigger?required_field=some textflag=trueorflag=falsearray_of_numbers=[17,18,19]object={"x":789}run_id=manual__12345(and expand the lower section seeing run_id being pre-populated)text=<script>alert(1)</script>(and see that it is not possible to XSS a value in)closes: #32859
FYI @AutomationDev85