Force Python 3.9+ version when building reproducible packages #37401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
amoghrajesh,
eladkal,
ephraimbuddy and
pankajkoti
jedcunningham
approved these changes
Feb 13, 2024
potiuk
force-pushed
the
fix-teething-problems-with-reproducible-packages
branch
3 times, most recently
from
dda9e2b to
464b2e3
Compare
potiuk
added
the
non committer build
potiuk
force-pushed
the
fix-teething-problems-with-reproducible-packages
branch
from
464b2e3 to
5b4023f
Compare
potiuk
force-pushed
the
fix-teething-problems-with-reproducible-packages
branch
from
aa91302 to
1c575ed
Compare
Member
Author
|
Turned out |
When building reproducible packages with Python 3.8 they are ... not reproducible. The tarfile produces slightly different output and packages are not binary identical. This change forces anyone preparing reproducible package to have breeze installed using Python 3.9+
potiuk
force-pushed
the
fix-teething-problems-with-reproducible-packages
branch
from
1c575ed to
8cf5216
Compare
Member
Author
|
And yes, also removed the |
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Feb 14, 2024
When building reproducible packages with Python 3.8 they are ... not reproducible. The tarfile produces slightly different output and packages are not binary identical. This change forces anyone preparing reproducible package to have breeze installed using Python 3.9+ (cherry picked from commit 4ae096e)
potiuk
added a commit
that referenced
this pull request
Feb 14, 2024
The #37401 forced Python 3.9 for all release commands that build reproducible packages. Thie PR sets Python 3.9 in the PROD image builds that run in release branches so that they also work.
potiuk
added a commit
that referenced
this pull request
Feb 14, 2024
The #37401 forced Python 3.9 for all release commands that build reproducible packages. Thie PR sets Python 3.9 in the PROD image builds that run in release branches so that they also work.
potiuk
added a commit
that referenced
this pull request
Feb 14, 2024
The #37401 forced Python 3.9 for all release commands that build reproducible packages. Thie PR sets Python 3.9 in the PROD image builds that run in release branches so that they also work.
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
When building reproducible packages with Python 3.8 they are ... not reproducible. The tarfile produces slightly different output and packages are not binary identical. This change forces anyone preparing reproducible package to have breeze installed using Python 3.9+ (cherry picked from commit 4ae096e)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
The #37401 forced Python 3.9 for all release commands that build reproducible packages. Thie PR sets Python 3.9 in the PROD image builds that run in release branches so that they also work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building reproducible packages with Python 3.8 they are ... not reproducible. The tarfile produces slightly different output and packages are not binary identical.
This change forces anyone preparing reproducible package to have breeze installed using Python 3.9+
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.