Fix permission check on DAGs when access_entity is specified
#37290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
approved these changes
Feb 9, 2024
hussein-awala
approved these changes
Feb 9, 2024
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
I just checked and realized that we don't have unit tests for these generic security helpers, it would be great if we could add some tests to (1) ensure they work as expected and (2) validate a bugfix like this one.
(The tests could be added later in a separate PR)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 2adbe88)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 2adbe88)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
requires_access_dagis used withaccess_entityspecified, it can lead to some inconsistencies.requires_access_dagshould check whether the user is authorized to read/edit at least one DAG (line 155) only when noaccess_entityis specified.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.