Skip to content

Workaround backwards-incompatibility in google-core-api 2.16.0 #37093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jan 30, 2024
Merged

Workaround backwards-incompatibility in google-core-api 2.16.0 #37093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/system/providers/google/cloud/dataproc/example_dataproc_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,17 @@
import os
from datetime import datetime

from google.api_core.retry_async import AsyncRetry
try:
from google.api_core.retry import AsyncRetry # type: ignore[attr-defined]
# There is a backwards-incompatible change in google.api_core.retry.AsyncRetry imports
# In 2.16.0 version of google-api-core, AsyncRetry was moved to google.api_core.retry_unary_async
# and backwards compatibility impots were not haandling the case of
# `from google.api_core.retry_async import AsyncRetry`
# The issue is tracked in https://github.com/googleapis/python-api-core/issues/586
# Until it is solved, we need to handle both cases, because one works before and one after 2.16.0
# But there is no import that works for both.
except ImportError:
from google.api_core.retry_async import AsyncRetry # type: ignore[attr-defined]

from airflow.models.dag import DAG
from airflow.providers.google.cloud.operators.dataproc import (
Expand Down