Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 28, 2024

The openapi-typescripts 6.7.4 generates slightly different typescript output and fails pre-commit. Using that opportunity to upgrade the environment for typescript/www compilation. Upgrading yarn to latest version and adding openapi-typescript to the dependencies will trigger re-creation of pre-commit venvs and make it the same for everyone


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The openapi-typescripts 6.7.4 generates slightly different
typescript output and fails pre-commit. Using that opportunity to
upgrade the environment for typescript/www compilation. Upgrading
yarn to latest version and adding openapi-typescript to the
dependencies will trigger re-creation of pre-commit venvs and make
it the same for everyone
@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jan 28, 2024
@potiuk potiuk requested review from ferruzzi and pankajkoti January 28, 2024 07:26
@potiuk
Copy link
Member Author

potiuk commented Jan 28, 2024

Static checks passed. Merging.

@potiuk potiuk merged commit 3b3494c into apache:main Jan 28, 2024
@potiuk potiuk deleted the upgrade-yarn-stack branch January 28, 2024 07:38
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.2 milestone Feb 19, 2024
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Feb 19, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
The openapi-typescripts 6.7.4 generates slightly different
typescript output and fails pre-commit. Using that opportunity to
upgrade the environment for typescript/www compilation. Upgrading
yarn to latest version and adding openapi-typescript to the
dependencies will trigger re-creation of pre-commit venvs and make
it the same for everyone

(cherry picked from commit 3b3494c)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
The openapi-typescripts 6.7.4 generates slightly different
typescript output and fails pre-commit. Using that opportunity to
upgrade the environment for typescript/www compilation. Upgrading
yarn to latest version and adding openapi-typescript to the
dependencies will trigger re-creation of pre-commit venvs and make
it the same for everyone

(cherry picked from commit 3b3494c)
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants