Handle SystemExit raised in the task. #36986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
* Exiting with a zero or None code signifies success, and the task does not return any value. * Exiting with other codes signifies an error.
potiuk
approved these changes
Jan 26, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice. Would be good to see why the Zombie case is happening but it's not necessary for this PR to fix it of course.
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Handle SystemExit raised in the task. * Add handling of system exit in tasks: * Exiting with a zero or None code signifies success, and the task does not return any value. * Exiting with other codes signifies an error. (cherry picked from commit 574d90f)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Handle SystemExit raised in the task. * Add handling of system exit in tasks: * Exiting with a zero or None code signifies success, and the task does not return any value. * Exiting with other codes signifies an error. (cherry picked from commit 574d90f)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #36809
Currently, we don't handle system exit events in tasks (e.g.
sys.exit()). Due to this, tasks remain in the running state, which can lead to undesired behavior in cases like #36809.