-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split contributing docs to multiple files #36969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ca022f
to
36006a7
Compare
5190817
to
e3adcd3
Compare
Following #36936 and the fact that GitHub stopped rendering big .rst files, we also split CONTRIBUTING.rst into multiplet files. It will be much easier to follow and it will render in GitHub.
7c40f9b
to
91eaeb8
Compare
Addressed @jscheffl comments. I target to merge it tomorrow - more comments welcome :) |
amoghrajesh
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the comments, @potiuk
LGTM +1 after a brief second iteration of review
Boom :) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 26, 2024
Yeah, of course apache#36969
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 27, 2024
This PR moves the documentation of CI of ours to inside Breeze doc folder and splits the documentation in separate docs / chapters following similar changes done for Breeze docs apache#36936 and the contributing docs apache#36969.
potiuk
added a commit
that referenced
this pull request
Jan 27, 2024
potiuk
added a commit
that referenced
this pull request
Feb 7, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:providers
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
provider:apache-beam
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #36936 and the fact that GitHub stopped rendering big .rst files, we also split CONTRIBUTING.rst into multiple files. It will be much easier to follow and it will render in GitHub.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.