Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split contributing docs to multiple files #36969

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 23, 2024

Following #36936 and the fact that GitHub stopped rendering big .rst files, we also split CONTRIBUTING.rst into multiple files. It will be much easier to follow and it will render in GitHub.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the refactor-contributing-docs branch 3 times, most recently from 1ca022f to 36006a7 Compare January 23, 2024 09:54
@potiuk potiuk force-pushed the refactor-contributing-docs branch 15 times, most recently from 5190817 to e3adcd3 Compare January 23, 2024 10:30
Following #36936 and the fact that GitHub stopped rendering big .rst
files, we also split CONTRIBUTING.rst into multiplet files. It will be
much easier to follow and it will render in GitHub.
@potiuk potiuk force-pushed the refactor-contributing-docs branch from 7c40f9b to 91eaeb8 Compare January 26, 2024 01:26
@potiuk
Copy link
Member Author

potiuk commented Jan 26, 2024

Addressed @jscheffl comments. I target to merge it tomorrow - more comments welcome :)

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the comments, @potiuk
LGTM +1 after a brief second iteration of review

@potiuk potiuk merged commit 8708bff into main Jan 26, 2024
81 checks passed
@potiuk
Copy link
Member Author

potiuk commented Jan 26, 2024

Boom :)

potiuk added a commit to potiuk/airflow that referenced this pull request Jan 26, 2024
potiuk added a commit that referenced this pull request Jan 26, 2024
potiuk added a commit to potiuk/airflow that referenced this pull request Jan 27, 2024
This PR moves the documentation of CI of ours to inside Breeze
doc folder and splits the documentation in separate docs / chapters
following similar changes done for Breeze docs apache#36936 and the
contributing docs apache#36969.
potiuk added a commit that referenced this pull request Jan 27, 2024
This PR moves the documentation of CI of ours to inside Breeze
doc folder and splits the documentation in separate docs / chapters
following similar changes done for Breeze docs #36936 and the
contributing docs #36969.
potiuk added a commit that referenced this pull request Feb 7, 2024
Following #36936 and the fact that GitHub stopped rendering big .rst
files, we also split CONTRIBUTING.rst into multiplet files. It will be
much easier to follow and it will render in GitHub.

(cherry picked from commit 8708bff)
potiuk added a commit that referenced this pull request Feb 7, 2024
This PR moves the documentation of CI of ours to inside Breeze
doc folder and splits the documentation in separate docs / chapters
following similar changes done for Breeze docs #36936 and the
contributing docs #36969.

(cherry picked from commit 6daceb8)
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 8, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 8, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
Following #36936 and the fact that GitHub stopped rendering big .rst
files, we also split CONTRIBUTING.rst into multiplet files. It will be
much easier to follow and it will render in GitHub.

(cherry picked from commit 8708bff)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
This PR moves the documentation of CI of ours to inside Breeze
doc folder and splits the documentation in separate docs / chapters
following similar changes done for Breeze docs #36936 and the
contributing docs #36969.

(cherry picked from commit 6daceb8)
@Taragolis Taragolis deleted the refactor-contributing-docs branch April 3, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:apache-beam
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants