Bump min version of Alembic to 1.13.1 #36928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+ Fixes: apache#36912
Contributor
|
Maybe we just need to exclude the version which has buggy behavior in SA 1.4? |
Taragolis
approved these changes
Jan 20, 2024
Member
Author
|
Thought about it and I generally prefer to bump it up in this case. Alembic has generally one purpose - keep our migrations working. And there is rather low probability someone will need a lower version of alembic for something else in airflow environment. And alembic has very few dependencies and they have low limits in this new version so no risk of other conflicts. I'd prefer in such cases to bump min versions with lower-binding. This has the nice side effect of people experiencing less bugs and security problems - and risks are IMHO rather low. |
2 tasks
potiuk
added a commit
that referenced
this pull request
Feb 7, 2024
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+
Fixes: #36912
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.