Fix bug introduced by replacing spaces by + in run_id #36877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on sanitizing the run_id(apache#32293), I replaced spaces with + which is not an ideal way to quote a URL. This led to issues when users use spaces in their DAG run_id. This commit fixes the issue by using urllib.parse.quote to properly quote the URL.
ephraimbuddy
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
dstandish
approved these changes
Jan 18, 2024
2 tasks
potiuk
reviewed
Jan 20, 2024
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on sanitizing the run_id(#32293), I replaced spaces with + which is not an ideal way to quote a URL. This led to issues when users use spaces in their DAG run_id.
This commit fixes the issue by using urllib.parse.quote to properly quote the URL.