Fix airflow-scheduler exiting with code 0 on exceptions #36800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jan 15, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Fix airflow-scheduler exiting with code 0 on exceptions * Fix static check (cherry picked from commit 1d5d502)
68 tasks
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 21, 2024
In apache#36800 author fixed zombie scheduler issue arising from context manager exit not being called, thus sub process not getting terminated. It was fixed by explicitly calling the `close` function on an ExitStack-managed context manager. Simpler / better / cleaner / more standard solution is to "fix" the underlying context managers by wrapping the yield in a try / finally.
dstandish
added a commit
that referenced
this pull request
Mar 21, 2024
In #36800 author fixed zombie scheduler issue arising from context manager exit not being called, thus sub process not getting terminated. It was fixed by explicitly calling the `close` function on an ExitStack-managed context manager. Simpler / better / cleaner / more standard solution is to "fix" the underlying context managers by wrapping the yield in a try / finally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #32707 has changed the scheduler to capture the exceptions (and not re-raising it) and it is making the scheduler always exit with code 0 (that means exit without error). In case of an
airflow-schedulerrunning in a docker container with the--restart alwaysoption set, the exit code 0 will make the container stop and not restart because docker will interpret it as the code ran and finished with success. So if you have a DB quick unavailability, theairflow-schedulerwill not try to recover by restarting it and it will stop, causing the airflow instance to crash (without the scheduler).So, this PR is raising the exception and forcing the process in context to terminate (closing the contexts in
stackonfinallyto keep avoiding the zombie scheduler #32706) and avoid the scheduler exiting with code 0.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.