Skip to content

Conversation

@ArvidMartensRenson
Copy link
Contributor

This pull request fixes the issue that failed tasks are not detected by the microsoft azure batch hook. Main origin of the bug is found in using an exhausted iterator again to find the failed tasks. This PR captures the tasks in a list first which is afterwards used to the tasks analysis (task completion and failure detection). A bug in the failure comparison is also resolved.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Jan 15, 2024

Can you add unit test to avoid regression?

@eladkal
Copy link
Contributor

eladkal commented Jan 15, 2024

@eladkal eladkal changed the title fix wait_for_job_tasks_to_complete in microsoft-azure provider Fix failed tasks are not detected in AzureBatchHook Jan 15, 2024
@eladkal eladkal requested a review from Lee-W January 16, 2024 08:04
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just traced the code. it indeed returns an iterator. Good finding!

@eladkal eladkal merged commit 57c9211 into apache:main Jan 16, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 16, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants