-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix failed tasks are not detected in AzureBatchHook
#36785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Can you add unit test to avoid regression? |
AzureBatchHook
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just traced the code. it indeed returns an iterator. Good finding!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This pull request fixes the issue that failed tasks are not detected by the microsoft azure batch hook. Main origin of the bug is found in using an exhausted iterator again to find the failed tasks. This PR captures the tasks in a list first which is afterwards used to the tasks analysis (task completion and failure detection). A bug in the failure comparison is also resolved.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.