-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset delete feature #36781
Add dataset delete feature #36781
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
131efe0
to
ddb8250
Compare
@potiuk re-requesting your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely have a confirmation step when deleting anything. Probably using this component in chakra: https://chakra-ui.com/docs/components/alert-dialog/usage
Let me know if you need help here.
38517e9
to
9a53a9a
Compare
@bbovenzi added confirmation modal and updated the recording. For now I followed the button spacing as in |
After looking at this again, I don't like how the delete button is so prevalent for what should be a pretty rare behavior. So that gives us two options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should hold before we conclude https://lists.apache.org/thread/q4sd09xymvlskxdgcb1s6gfsqwnvqs2o discussion (so I am doing "Request changes" unti it does - and end up with a VOTE or CONSENSUS).
Whether to create/delete datasets externally is a decision that should be made deliberately, and there are various voices there - some (including myself) think that dataset management should be done internally by Airflow (including possibly reference counting and automatically removing datasets that are not referred by any DAGS) while some others think that there is a value in managing datasets from outside. Until that discussion concludes, I think we should hold on with merging this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should hold before we conclude https://lists.apache.org/thread/q4sd09xymvlskxdgcb1s6gfsqwnvqs2o discussion (so I am doing "Request changes" unti it does - and end up with a VOTE or CONSENSUS).
Whether to create/delete datasets externally is a decision that should be made deliberately, and there are various voices there - some (including myself) think that dataset management should be done internally by Airflow (including possibly reference counting and automatically removing datasets that are not referred by any DAGS) while some others think that there is a value in managing datasets from outside. Until that discussion concludes, I think we should hold on with merging this change.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This PR add a feature to delete dataset from both UI and API to address #36308 with necessary tests and API specification.
delete_dataset_ui_modal.mp4
delete_dataset_api.mp4
closes: #36308
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.