Remove wrong changelog about default Python version in the image #36777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apache#36003 we **thought** we changed default "version" image to point to "newest" python version not to the "oldest" supported one - as agreed in https://lists.apache.org/thread/0oxnvct24xlqsj76z42w2ttw2d043oy3 However as observed and tracked in apache#36740 the change was not effective. We only changed the moment at which latest image is pointing to 2.8.0 but not whether 2.8.0 points to `python-3.8` or `python-3.11'. This means that we should only do that change for Python 3.9 qnd revert the changelog (and cherry-pick it to 2.8.1)
boring-cyborg
bot
added
area:production-image
Member
Author
|
We should merge that one to 2.8.1 - this is a changelog fix only |
hussein-awala
approved these changes
Jan 14, 2024
Taragolis
approved these changes
Jan 14, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 14, 2024
The change apache#36003 attempted to change which Python version is used for the "default" image ("2.8.0" and effectively "latest as well). But it failed to do so - because of a bug. The changelog about this have been removed in apache#36777 and we are bringing the change back (this time properly implemented) and changelog - with aim to release it in Airflow 2.9.0. Fixes: apache#36740
Member
Author
|
Cherry-picked to 2.8.1 @ephraimbuddy |
potiuk
added a commit
that referenced
this pull request
Jan 15, 2024
The change #36003 attempted to change which Python version is used for the "default" image ("2.8.0" and effectively "latest as well). But it failed to do so - because of a bug. The changelog about this have been removed in #36777 and we are bringing the change back (this time properly implemented) and changelog - with aim to release it in Airflow 2.9.0. Fixes: #36740
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
) In #36003 we **thought** we changed default "version" image to point to "newest" python version not to the "oldest" supported one - as agreed in https://lists.apache.org/thread/0oxnvct24xlqsj76z42w2ttw2d043oy3 However as observed and tracked in #36740 the change was not effective. We only changed the moment at which latest image is pointing to 2.8.0 but not whether 2.8.0 points to `python-3.8` or `python-3.11'. This means that we should only do that change for Python 3.9 qnd revert the changelog (and cherry-pick it to 2.8.1) (cherry picked from commit 270b112)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36003 we thought we changed default "version" image to point to "newest" python version not to the "oldest" supported one - as agreed in https://lists.apache.org/thread/0oxnvct24xlqsj76z42w2ttw2d043oy3
However as observed and tracked in #36740 the change was not effective. We only changed the moment at which latest image is pointing to 2.8.0 but not whether 2.8.0 points to
python-3.8or `python-3.11'.This means that we should only do that change for Python 3.9 qnd revert the changelog (and cherry-pick it to 2.8.1)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.