Simplify how mypy "folder" checks are run #36760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
Taragolis,
dstandish,
ferruzzi,
jscheffl and
pankajkoti
Member
Author
|
Suggested by @jscheffl in #36638 (comment) |
potiuk
force-pushed
the
simplify-mypy-folder-checks
branch
from
372738c to
e05d554
Compare
The apache#36638 change introduced "full package" checks - where in case of CI we run mypy checks separately from regular static checks, for the whole folders. However it's been a little convoluted on how the checks were run, with a separate env variable. Instead we can actually have multiple mypy-* checks (same as we have for local pre-commit runs) as mypy allows to have multiple checks with the same name in various stages. This change simplifies the setup a bit: * we name the checks "folder" checks because this is what they are * we name the check names consistent ("airflow", "providers", "docs", "dev") with mypy-folders output * we have separate small script to run the folder checks * we map "providers" into "airflow/providers" in the pre-commit
potiuk
force-pushed
the
simplify-mypy-folder-checks
branch
from
e05d554 to
45fc14c
Compare
Taragolis
approved these changes
Jan 13, 2024
jscheffl
approved these changes
Jan 13, 2024
potiuk
added a commit
that referenced
this pull request
Jan 13, 2024
The #36638 change introduced "full package" checks - where in case of CI we run mypy checks separately from regular static checks, for the whole folders. However it's been a little convoluted on how the checks were run, with a separate env variable. Instead we can actually have multiple mypy-* checks (same as we have for local pre-commit runs) as mypy allows to have multiple checks with the same name in various stages. This change simplifies the setup a bit: * we name the checks "folder" checks because this is what they are * we name the check names consistent ("airflow", "providers", "docs", "dev") with mypy-folders output * we have separate small script to run the folder checks * we map "providers" into "airflow/providers" in the pre-commit (cherry picked from commit a912948)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
The #36638 change introduced "full package" checks - where in case of CI we run mypy checks separately from regular static checks, for the whole folders. However it's been a little convoluted on how the checks were run, with a separate env variable. Instead we can actually have multiple mypy-* checks (same as we have for local pre-commit runs) as mypy allows to have multiple checks with the same name in various stages. This change simplifies the setup a bit: * we name the checks "folder" checks because this is what they are * we name the check names consistent ("airflow", "providers", "docs", "dev") with mypy-folders output * we have separate small script to run the folder checks * we map "providers" into "airflow/providers" in the pre-commit (cherry picked from commit a912948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #36638 change introduced "full package" checks - where in case of CI we run mypy checks separately from regular static checks, for the whole folders.
However it's been a little convoluted on how the checks were run, with a separate env variable. Instead we can actually have multiple mypy-* checks (same as we have for local pre-commit runs) as mypy allows to have multiple checks with the same name in various stages.
This change simplifies the setup a bit:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.