Skip to content

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Jan 10, 2024

We forget to change default value for INSTALL_MYSQL_CLIENT_TYPE argument to mariadb.
So we build packages by MariaDB libraries, however finally install mysql.
This only affects X86_64 images because for ARM we always use MariaDB libraries regardless of this build argument

related: #36715 (this only fix further images, but not 2.8)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added this to the Airflow 2.8.1 milestone Jan 10, 2024
@Taragolis Taragolis requested review from ashb and potiuk as code owners January 10, 2024 17:46
@boring-cyborg boring-cyborg bot added the area:production-image Production image improvements and fixes label Jan 10, 2024
@potiuk
Copy link
Member

potiuk commented Jan 10, 2024

I guess we should also mention that in the docker-stack release notes (changing 2.8.0 -> 2.8.1) ?

@Taragolis
Copy link
Contributor Author

Yeah I think also need to mention that if someone build custom image from 2.8.0 branch then should specify INSTALL_MYSQL_CLIENT_TYPE=mariadb

Let me find better place for that

@potiuk potiuk merged commit 11ec410 into main Jan 10, 2024
@potiuk
Copy link
Member

potiuk commented Jan 10, 2024

@potiuk
Copy link
Member

potiuk commented Jan 10, 2024

OK. Images refreshed - they failed verification, but the verification failure was "fab" provider missing (which is expected).

ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 15, 2024
@Taragolis Taragolis deleted the fix-default-mysql-client-for-prod branch February 16, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants