Fix run type icon alignment with run type text #36616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamy7
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
Contributor
Author
|
cc: amoghrajesh |
eladkal
added
the
type:misc/internal
bbovenzi
approved these changes
Jan 5, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 70be78f)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #36574
There is a mis-alignment with the run type icon and the run type text.
This PR resolve this issue by declaring the
vertical-alignproperty.Before this PR, the run type looked like this:
After this PR, the run type will look like this:
I have tested all other icons (scheduled, backfill, dataset_triggered) as well, all looks better now :)