Tracking airflow-github changelog activities using progress bar #36610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
jedcunningham and
potiuk
as code owners
ephraimbuddy
reviewed
Jan 5, 2024
Contributor
Author
|
@ephraimbuddy this is how it looks now: |
ephraimbuddy
approved these changes
Jan 5, 2024
potiuk
approved these changes
Jan 5, 2024
potiuk
pushed a commit
that referenced
this pull request
Jan 13, 2024
* Tracking airflow-github changelog activities using progress bar * review comments from ephraimbuddy (cherry picked from commit b3b8ae9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Tracking airflow-github changelog activities using progress bar * review comments from ephraimbuddy (cherry picked from commit b3b8ae9)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Jarek, long running tasks like changelog in airflow-github are hard to track without a progress bar, adding Rich library's progress bar to this task
Small excerpt into how it looks:
PostToGithub.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.