Check executable permission for entrypoints at breeze start #36482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes our contributors check out Airflow repository on filesystems that are not POSIX compliant and do not have support for executable bits (for example when you check-out the repository in Windows and attempt to map it to a Linux VM). Breeze and building CI images will not work in this case, but the error that you see might be misleading. This PR performs additional environment check and informs you that you should not do it, if executable bits are missing from entrypoints.
Taragolis
approved these changes
Dec 29, 2023
jscheffl
approved these changes
Dec 29, 2023
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Small wording recommondation only, else approved.
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk
added a commit
that referenced
this pull request
Dec 30, 2023
* Check executable permission for entrypoints at breeze start Sometimes our contributors check out Airflow repository on filesystems that are not POSIX compliant and do not have support for executable bits (for example when you check-out the repository in Windows and attempt to map it to a Linux VM). Breeze and building CI images will not work in this case, but the error that you see might be misleading. This PR performs additional environment check and informs you that you should not do it, if executable bits are missing from entrypoints. * Update dev/breeze/src/airflow_breeze/utils/docker_command_utils.py Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> (cherry picked from commit 5551e14)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes our contributors check out Airflow repository on filesystems that are not POSIX compliant and do not have support for executable bits (for example when you check-out the repository in Windows and attempt to map it to a Linux VM). Breeze and building CI images will not work in this case, but the error that you see might be misleading.
This PR performs additional environment check and informs you that you should not do it, if executable bits are missing from entrypoints.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.