Fix preparing rc candidates for providers #36465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last auto-upgrade RC implementd in apache#36441 had a bug - it was bumping rc even for providers that have been already released. This change fixes it - it skips packages that already have "final" tag present in the repo. It also explicitely calls "Apply template update" as optional step - only needed in case we modify templates and want to update automatically generated documentation with it.
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
pierrejeambrun
as code owners
Taragolis
approved these changes
Dec 28, 2023
hussein-awala
approved these changes
Dec 28, 2023
eladkal
approved these changes
Dec 28, 2023
potiuk
added a commit
that referenced
this pull request
Dec 30, 2023
The last auto-upgrade RC implementd in #36441 had a bug - it was bumping rc even for providers that have been already released. This change fixes it - it skips packages that already have "final" tag present in the repo. It also explicitely calls "Apply template update" as optional step - only needed in case we modify templates and want to update automatically generated documentation with it. (cherry picked from commit a3e5a97)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last auto-upgrade RC implementd in #36441 had a bug - it was bumping rc even for providers that have been already released. This change fixes it - it skips packages that already have "final" tag present in the repo. It also explicitely calls "Apply template update" as optional step - only needed in case we modify templates and want to update automatically generated documentation with it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.