Refactor _manage_executor_state by refreshing TIs in batch #36418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
hussein-awala
added
the
use public runners
Member
|
Nice one! @hussein-awala -> I just wonder if that could be the reason for #36454 |
potiuk
approved these changes
Dec 29, 2023
Member
|
It fails in main for MSSQL. We are planning to cherry-pick that one for 2.8.1 so I hope it's the last that requires MSSQL special treatment (I guess you need to open fixup PR and set |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 30, 2023
…pache#36418)" This reverts commit 9d45db9. t#
potiuk
added a commit
that referenced
this pull request
Dec 30, 2023
hussein-awala
added a commit
to hussein-awala/airflow
that referenced
this pull request
Dec 30, 2023
…batch (apache#36418)" (apache#36500)" This reverts commit 72f43fc.
potiuk
pushed a commit
that referenced
this pull request
Dec 30, 2023
ephraimbuddy
added
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Refactor _manage_executor_state by refreshing TIs in batch * Use a short key without retry number (cherry picked from commit 9d45db9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #7370
This PR improves the performance of the method
_manage_executor_stateby fetching the state of all the running TIs in a single query instead of refreshing them one by one from the DB.