Use base aws classes in Amazon ECS Operators/Sensors/Triggers

[jayceslesar]

Similar to #35133 (relates to #35278)

Unsure how to get tests passing for test_hook_and_client in tests/providers/amazon/aws/operators/test_ecs.py, because it seems like it should just work 🤷

[Taragolis]

Unsure how to get tests passing for test_hook_and_client in tests/providers/amazon/aws/operators/test_ecs.py, because it seems like it should just work 🤷

The better is rewrite, because in this case it mock different object. You need to mock airflow.providers.amazon.aws.operators.ecs.EcsBaseOperator.aws_hook_class however it would not work because it would fail on subclass check

You could split it by two test in first just check that expected argument are passed into the hook constructor, something similar to the

airflow/tests/providers/amazon/aws/operators/test_athena.py

Lines 80 to 101 in 5626590

	def test_base_aws_op_attributes(self):
	op = AthenaOperator(**self.default_op_kwargs)
	assert op.hook.aws_conn_id == "aws_default"
	assert op.hook._region_name is None
	assert op.hook._verify is None
	assert op.hook._config is None
	assert op.hook.log_query is True
	op = AthenaOperator(
	**self.default_op_kwargs,
	aws_conn_id="aws-test-custom-conn",
	region_name="eu-west-1",
	verify=False,
	botocore_config={"read_timeout": 42},
	log_query=False,
	)
	assert op.hook.aws_conn_id == "aws-test-custom-conn"
	assert op.hook._region_name == "eu-west-1"
	assert op.hook._verify is False
	assert op.hook._config is not None
	assert op.hook._config.read_timeout == 42
	assert op.hook.log_query is False

And second test just mock hook property and check and check client property

[jayceslesar]

@Taragolis thank you for the review -- all but mocking the hook property and client property should be all set. Pretty unsure how to best do that? Should I just test that the hook was not called and keep the client portion of the test the same?

[Taragolis]

It could be something like that.

        with mock.patch.object(EcsBaseOperator, "hook", new_callable=mock.PropertyMock) as m:
            mocked_hook = mock.MagicMock(name="FakeHook")
            mocked_client = mock.MagicMock(name="FakeBoto3Client")
            mocked_hook.conn = mocked_client
            m.return_value = mocked_hook

            assert op.client == mocked_client
            m.assert_called_once()

[Taragolis]

And after that you could remove test_hook_and_client because it not required anymore after that

[jayceslesar]

Thank you for the example!

[Taragolis]

Need to fix Static Checks:

• you could run locally breeze static-checks {id-of-failed-check} --all-files e.g. breeze static-checks ruff --all-files
• Another option run it thought pre-commit pre-commit run {id-of-failed-check} --all-files e.g. pre-commit run ruff --all-files

You could have a look what failed in Tests / Static checks (pull_request) logs

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.