Remove rendundant and unused code in docs building/publishing #36346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently docs building happens insid of the container image and code doing that sits in `docs` folder, while publishing has already been moved to `breeze` code (and is executed in the Breeze venv, not in the container). Both building and publishing code were present in both (copy&pasted) and the parts of it not relevant to the `other` function has not been used. While eventually we will move docs building also to `breeze` the first step of that is to remove the redundancy and clean-up unused code, so that we can make the transition cleaner.
potiuk
requested review from
Lee-W,
amoghrajesh,
eladkal and
pierrejeambrun
and removed request for
ashb and
jedcunningham
eladkal
approved these changes
Dec 21, 2023
Lee-W
approved these changes
Dec 21, 2023
potiuk
added a commit
that referenced
this pull request
Dec 30, 2023
Currently docs building happens insid of the container image and code doing that sits in `docs` folder, while publishing has already been moved to `breeze` code (and is executed in the Breeze venv, not in the container). Both building and publishing code were present in both (copy&pasted) and the parts of it not relevant to the `other` function has not been used. While eventually we will move docs building also to `breeze` the first step of that is to remove the redundancy and clean-up unused code, so that we can make the transition cleaner. (cherry picked from commit bf90992)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently docs building happens insid of the container image and code doing that sits in
docsfolder, while publishing has already been moved tobreezecode (and is executed in the Breeze venv, not in the container). Both building and publishing code were present in both (copy&pasted) and the parts of it not relevant to theotherfunction has not been used.While eventually we will move docs building also to
breezethe first step of that is to remove the redundancy and clean-up unused code, so that we can make the transition cleaner.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.