Do not let EventsTimetable schedule past events if catchup=False #36134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
Dec 9, 2023
jscheffl
approved these changes
Dec 11, 2023
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Did a regressio with the example included in the bug report and this PR fixed it.
Contributor
|
@uranusjr As you are tagged as Codeowner, can you make another review before merge? Alternatively @Taragolis please make a second pass and then OK to merge? |
uranusjr
changed the title
uranusjr
reviewed
Dec 13, 2023
Member
|
Looks right to me in general, just a minor idea on implementation. I also pushed a commit to improve typing slightly. |
By coercing things to Pendulum, we can save a bunch of ignores and explicit annotations.
eladkal
force-pushed
the
33948_bug_eventstimetable_schedules_past_events
branch
from
26a7a09 to
d659a4f
Compare
eladkal
approved these changes
Jan 10, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
) * Fix the EventsTimetable schedules past events bug --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit c01daf8)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
) * Fix the EventsTimetable schedules past events bug --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit c01daf8)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33948
Fixed the bug and added some more tests.