Add processor_subdir to import_error table to handle multiple dag processors #35956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
XD-DENG,
ashb,
ephraimbuddy,
jedcunningham,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:Scheduler
tirkarthi
force-pushed
the
dag-processor-subdir
branch
from
4d1d6c1 to
5865dda
Compare
mhenc
approved these changes
Nov 30, 2023
Contributor
mhenc
left a comment
mhenc
left a comment
There was a problem hiding this comment.
Looks good. Thank you for the fix!
Contributor
Author
|
The other issue we had on switching from one dag processor to multiple ones using subdir was that old import errors were not deleted as they had different directory. It will be the same issue on switching to single dag processor from subdir based approach and needs a one time cleanup of import error table. Just noting this down if anyone encounters it. |
Contributor
|
Took me a while to find this PR and specifically your comment above @tirkarthi , but thank you for noting this behavior! Made for an easy fix and understanding of how this occurred on a client's airflow deployment 🖖 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add processor_subdir to import_error table to update the value while creating ImportError entry. Use the processor_subdir to filter for ImportError entries that belong to the current dag processor.
closes: #35949
related: #35949