Stop converting state to TaskInstanceState when it's None #35891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
vincbeck
approved these changes
Nov 27, 2023
Taragolis
approved these changes
Nov 27, 2023
Contributor
|
Thanks @hussein-awala for the quick fix. We will try to test this patch in next Kubernetes provider release since this missed the current RC provider candidate. |
50 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by #32627, where we try to get the state from the database when it's None in the executor, and for some reason, it's None in the database(maybe the task is cleared or its state is set manually to None...); in this case, we cannot convert it to
TaskInstanceState, and we should use None as before the mentioned PR.closes: #35888