Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish refactoring of breeze-dependent pre-commits to use breeze shell #35830

Merged

Commits on Nov 27, 2023

  1. Finish refactoring of breeze-dependent pre-commits to use breeze shell

    Some of our pre-commits were using code from Breeze in rather complex
    way - by inserting PYTHONPATH and importing code from there. That was
    complex and brittle and with recent changes of ShelParam apache#35801 those
    precommits required more and more dependencies to be added to their
    pre-commit virtualenvs.
    
    The reason that it was done this way was the assumption that someone
    might want to run pre-commits locally without having breeze installed,
    but this assumption and use case is rather unlikely, becasue breeze
    becomes more and more useful and used so we can safely assume that
    anyone who wants to do pre-commits will also have breeze installed and
    on path. And anyway to run those pre-commits you need to have breeze
    CI image pulled and built, so you should generally have breeze to run
    them.
    
    This PR finishes the series of PRs implementing the refactor and
    completes the refactor.
    potiuk committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0a1e6fa View commit details
    Browse the repository at this point in the history