Skip to content

Add a filter for local files in GoogleDisplayVideo360CreateQueryOperator #35635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hussein-awala merged 1 commit into from
Nov 14, 2023
Merged

Add a filter for local files in GoogleDisplayVideo360CreateQueryOperator #35635

hussein-awala merged 1 commit into from
Nov 14, 2023

Conversation

@hussein-awala
Copy link
Member

@hussein-awala hussein-awala commented Nov 14, 2023 •
edited
Loading

In a complex scenario, this operator could be used to upload local files to GCS instead of uploading DV360 reports.

This PR adds a filter for local files to stop the execution.

echo "test text" > /tmp/test.txt
python -c "import urllib.request; print(urllib.request.urlopen('file:/tmp/test.txt').file.read())"

related: #35615

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 14, 2023
@hussein-awala hussein-awala merged commit 9d5f726 into apache:main Nov 14, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Nov 20, 2023
@eladkal eladkal mentioned this pull request Nov 24, 2023
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@vincbeck vincbeck vincbeck approved these changes

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

@eladkal eladkal Awaiting requested review from eladkal

Assignees

No one assigned

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hussein-awala @potiuk @vincbeck @ephraimbuddy