Remove sqla module from security manager
#35557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
potiuk
approved these changes
Nov 9, 2023
Member
|
I love the direction it takes :D |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 layers of security managers:
airflow.www.fab_security.manager.BaseSecurityManagerairflow.www.fab_security.sqla.manager.SecurityManagerairflow.www.security_manager.AirflowSecurityManagerV2airflow.auth.managers.fab.security_manager.override.FabAirflowSecurityManagerOverrideThe first 3 layers of security managers are in core Airflow. As part of AIP-56, we moved quite a lot of methods/properties from these security managers to the FAB security manager override (
airflow.auth.managers.fab.security_manager.override.FabAirflowSecurityManagerOverride). Thus, the first 3 layers start getting smaller and I dont see any value keeping them separated in 3 different files. The end goal is to merge the first 3 layers of security managers into one (airflow.www.security_manager.AirflowSecurityManagerV2). This PR removes theairflow.www.fab_security.sqla.manager.SecurityManager.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.