Add borderWidthRight to grid for Firefox scrollbar #35346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiapaikeo
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
2 tasks
Contributor
Author
|
@pierrejeambrun , wdyt? I tried other options like manipulating scrollbar-gutter, adding extra padding, and margin but none seemed to work. |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v2
branch
from
5702013 to
a0ba9cf
Compare
Contributor
We have a padding right |
Contributor
Author
|
@bbovenzi , this seems to work for Chrome but doesn't work for Firefox :-( Untitled.mov |
bbovenzi
approved these changes
Nov 17, 2023
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
if it works in chrome and firefox then this is good.
Contributor
Author
|
@eladkal , wdyt? Okay to merge here? |
eladkal
approved these changes
Nov 22, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 23, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #35074
Before:
bad-scrollbar-s.mov
After:
add-border-width-right-s.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.