Clean local tags in tag_providers for network issues with Github #34951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
jedcunningham,
kaxil,
pierrejeambrun and
potiuk
as code owners
Contributor
Author
|
@eladkal @ephraimbuddy handling this like this as per offline discussions. Do let me know what you feel cc @potiuk |
potiuk
approved these changes
Oct 15, 2023
Member
|
LGTM. @eladkal ? |
eladkal
reviewed
Oct 15, 2023
Comment on lines
-39
to
+41
| git push $remote "${tags[@]}" | ||
| if git push $remote "${tags[@]}"; then | ||
| echo "Tags pushed successfully" |
Contributor
There was a problem hiding this comment.
Normally the script outputs:
➜ airflow git:(main) ./dev/provider_packages/tag_providers.sh
Enumerating objects: 82, done.
Counting objects: 100% (82/82), done.
Delta compression using up to 10 threads
Compressing objects: 100% (82/82), done.
Writing objects: 100% (82/82), 3.33 KiB | 682.00 KiB/s, done.
Total 82 (delta 79), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (79/79), done.
To https://github.com/apache/airflow.git
* [new tag] providers-airbyte/3.4.0rc1 -> providers-airbyte/3.4.0rc1
* [new tag] providers-alibaba/2.6.0rc1 -> providers-alibaba/2.6.0rc1
* [new tag] providers-amazon/8.8.0rc1 -> providers-amazon/8.8.0rc1
* [new tag] providers-apache-beam/5.3.0rc1 -> providers-apache-beam/5.3.0rc1
* [new tag] providers-apache-cassandra/3.3.0rc1 -> providers-apache-cassandra/3.3.0rc1
* [new tag] providers-apache-drill/2.5.0rc1 -> providers-apache-drill/2.5.0rc1
* [new tag] providers-apache-druid/3.6.0rc1 -> providers-apache-druid/3.6.0rc1
* [new tag] providers-apache-flink/1.2.0rc1 -> providers-apache-flink/1.2.0rc1
* [new tag] providers-apache-hdfs/4.2.0rc1 -> providers-apache-hdfs/4.2.0rc1
* [new tag] providers-apache-hive/6.2.0rc1 -> providers-apache-hive/6.2.0rc1
* [new tag] providers-apache-impala/1.2.0rc1 -> providers-apache-impala/1.2.0rc1
* [new tag] providers-apache-kafka/1.2.0rc1 -> providers-apache-kafka/1.2.0rc1
If I read this right now the script will not output this but Tags pushed successfully ?
Contributor
Author
There was a problem hiding this comment.
I see your point, the standard output was being compromised. Can you try with the latest commit?
Member
There was a problem hiding this comment.
I think the original code was correct (and simpler).
if git push $remote "${tags[@]}"; then
would still output the stdout/stderr to terminal.
Contributor
Author
Contributor
There was a problem hiding this comment.
Sure if the output is present then lets.
I will test it with next release
eladkal
approved these changes
Oct 15, 2023
amoghrajesh
force-pushed
the
localTagCleaning
branch
from
0dd4113 to
464cca4
Compare
potiuk
pushed a commit
that referenced
this pull request
Oct 29, 2023
) (cherry picked from commit 1e9c807)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on slack, sometimes due to network connectivity issues with Github, our tag_providers.sh script creates tags locally with errors like:
in cases when the tag could not be pushed. This is irritating because now the release team has to manually delete these tags. Adding ability to do this using an env variable. The default behaviour here is that the tags will be cleaned locally.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.