Refactor: Extract and reuse get_kerberos_principle func from get_kerberos_principle #34936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Oct 14, 2023
Contributor
|
Is it possible to have a unit test for this function? |
hussein-awala
approved these changes
Oct 14, 2023
Lee-W
approved these changes
Oct 16, 2023
Contributor
Author
I added some tests |
eladkal
approved these changes
Oct 16, 2023
uranusjr
reviewed
Oct 16, 2023
uranusjr
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_kerberos_principle function for reuse in PR #34386 to simplify release management.