Skip to content

Make Dataprep system test self-sufficient #34880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Oct 26, 2023
Merged

Make Dataprep system test self-sufficient #34880

potiuk merged 1 commit into from
Oct 26, 2023

Conversation

@moiseenkov
Copy link
Contributor

@moiseenkov moiseenkov commented Oct 12, 2023

  1. Made Dataprep system test self-sufficient - from now it creates all needed objects and removes them afterwards.
  2. For making the previous point achievable, I added a few methods into the hook and covered them by unit tests.
  3. I also added a small bugfix for DataprepGetJobsForJobGroupOperator - it is now using connection id given by user instead of hardcoded value.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Oct 12, 2023
@moiseenkov moiseenkov force-pushed the system_tests/dataprep branch from 128296f to 04d22e9 Compare October 12, 2023 08:28
eladkal
eladkal previously requested changes Oct 12, 2023
View reviewed changes
@moiseenkov moiseenkov force-pushed the system_tests/dataprep branch 2 times, most recently from 709c38d to 2ff9ec3 Compare October 12, 2023 14:05
@moiseenkov moiseenkov requested a review from eladkal October 12, 2023 14:18
@moiseenkov moiseenkov force-pushed the system_tests/dataprep branch 4 times, most recently from 9ae967b to 5b9e4a4 Compare October 17, 2023 08:20
@moiseenkov
Copy link
Contributor Author

moiseenkov commented Oct 17, 2023

@eladkal , hi
Could you please take a look at my fixes? Thank you!

@moiseenkov moiseenkov force-pushed the system_tests/dataprep branch 6 times, most recently from 5946998 to 375b975 Compare October 24, 2023 13:17
@moiseenkov
Copy link
Contributor Author

moiseenkov commented Oct 25, 2023

@potiuk , hi,
Could we merge it please?

@potiuk
Copy link
Member

potiuk commented Oct 25, 2023 •
edited
Loading

@potiuk , hi, Could we merge it please?

As soon as @eladkal changes his review status. Until that I CAN't merge it.

@moiseenkov moiseenkov force-pushed the system_tests/dataprep branch from 375b975 to 07c3c82 Compare October 26, 2023 08:55
@potiuk potiuk merged commit acff4c7 into apache:main Oct 26, 2023
@eladkal eladkal mentioned this pull request Oct 28, 2023
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@eladkal eladkal Awaiting requested review from eladkal

Assignees

No one assigned

Labels

area:providers area:system-tests provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moiseenkov @potiuk @eladkal