Skip to content

Conversation

@dstandish
Copy link
Contributor

The argument is deprecated and it's advised to use the params directly.

@jedcunningham
Copy link
Member

When was it deprecated / when was params directly supported? Just trying to figure out if we have a new min version of ES we support or something.

@dstandish dstandish marked this pull request as draft October 5, 2023 22:22
@dstandish
Copy link
Contributor Author

Yeah saw test failures. I'm seeing the deprecation at version 8.1

We have it pinned at >8, <9 it seems. marked draft for now

@eladkal
Copy link
Contributor

eladkal commented Oct 6, 2023

cc @Owen-CH-Leung you mentioned the count api in https://github.com/apache/airflow/pull/33135/files#r1285877721

@Owen-CH-Leung
Copy link
Contributor

Owen-CH-Leung commented Oct 6, 2023

Hmm Indeed. It looks like body param is getting deprecated soon. I was diving into the v8.10.0 library (the latest v8 one) here, and I believe it will print this warning message (but strange I didn't see this warning when I was doing the upgrade before / testing the remote logging capability )

https://github.com/elastic/elasticsearch-py/blob/v8.10.0/elasticsearch/_sync/client/utils.py#L393-L404

@dstandish
Copy link
Contributor Author

dstandish commented Oct 6, 2023

I fixed (in this PR) the calls so that they work with 8.10...

I have a hunch that to fix the tests in this PR we'll need to bump es version to 8.10

@dstandish dstandish force-pushed the handle-deprecation-of-body-arg branch from 6a90539 to 1e36f0f Compare November 7, 2023 20:57
The argument is deprecated and it's advised to use the params directly.
@dstandish dstandish force-pushed the handle-deprecation-of-body-arg branch from e30e04a to 534b456 Compare November 9, 2023 00:29
@dstandish
Copy link
Contributor Author

OK I tested this change locally and it does require bumping min elasticsearch version to 8.10 (which i have updated the provider settings to do)

So, presuming tests pass, this should be good to go

@dstandish dstandish marked this pull request as ready for review November 9, 2023 00:30
@potiuk
Copy link
Member

potiuk commented Nov 9, 2023

Nice. I like when our provider's min versions of dependencies got update. I am actualy thinking of adding a check for it - i.e. attempting to install lowest versions of dependencies possible and running our tests on it. That would be an ulitmate check whether our min requirements

I captured it here #35549 and I will likely find some time to implement it in the coming months, though if someone else would like to pick it up, I am happy to guide them and work together.

@potiuk potiuk merged commit 0d7fe47 into apache:main Nov 9, 2023
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:elasticsearch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants