-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update es read query to not use body #34792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When was it deprecated / when was params directly supported? Just trying to figure out if we have a new min version of ES we support or something. |
|
Yeah saw test failures. I'm seeing the deprecation at version 8.1 We have it pinned at >8, <9 it seems. marked draft for now |
|
cc @Owen-CH-Leung you mentioned the count api in https://github.com/apache/airflow/pull/33135/files#r1285877721 |
|
Hmm Indeed. It looks like |
|
I fixed (in this PR) the calls so that they work with 8.10... I have a hunch that to fix the tests in this PR we'll need to bump es version to 8.10 |
6a90539 to
1e36f0f
Compare
The argument is deprecated and it's advised to use the params directly.
e30e04a to
534b456
Compare
|
OK I tested this change locally and it does require bumping min elasticsearch version to 8.10 (which i have updated the provider settings to do) So, presuming tests pass, this should be good to go |
|
Nice. I like when our provider's min versions of dependencies got update. I am actualy thinking of adding a check for it - i.e. attempting to install lowest versions of dependencies possible and running our tests on it. That would be an ulitmate check whether our min requirements I captured it here #35549 and I will likely find some time to implement it in the coming months, though if someone else would like to pick it up, I am happy to guide them and work together. |
The argument is deprecated and it's advised to use the params directly.