Add ability to clear downstream tis in "List Task Instances" view #34529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:webserver
peloyeje
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
SamWheating
reviewed
Sep 21, 2023
peloyeje
force-pushed
the
feature/clear-with-downstream
branch
2 times, most recently
from
3977962 to
4ad02d1
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Tested locally, looking nice
peloyeje
force-pushed
the
feature/clear-with-downstream
branch
from
ca8cfaa to
9e5a466
Compare
Contributor
Author
|
Just pushed yet another tweaks to the initial implementation so that |
peloyeje
requested review from
SamWheating,
hussein-awala and
pierrejeambrun
hussein-awala
approved these changes
Sep 22, 2023
| task_id for task_id in partial_dag.task_dict if task_id not in task_ids_to_clear | ||
| ] | ||
|
|
||
| # dag.clear returns TIs when in dry run mode |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Member
|
Congrats Jean-Eudes on your first commit 🎉 |
Contributor
Author
|
Thanks everyone for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "clear (including downstream)" action in the "List Task Instances" view
Also a bit of refactoring so that "clear" / "clear including downstream" share the same logic
Added a unit test to make sure clearing logic is "run-aware"
closes: #33014
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.