Skip to content

Conversation

@moiseenkov
Copy link
Contributor

Refactored buggy DataFusionPipelineLinkHelper into a more generic function.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 21, 2023
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@moiseenkov moiseenkov force-pushed the datafusion_refactor_project_id branch 2 times, most recently from dffbc9a to cdd769f Compare October 2, 2023 09:56
@moiseenkov moiseenkov requested a review from eladkal October 2, 2023 11:54
@moiseenkov
Copy link
Contributor Author

@eladkal , @kaxil , @Taragolis , hi,
can we merge this please?

@moiseenkov moiseenkov force-pushed the datafusion_refactor_project_id branch 2 times, most recently from ffa8139 to 685c277 Compare October 5, 2023 13:48
@VladaZakharova
Copy link
Contributor

@eladkal @potiuk
Hi Team! Can you please take a look on the changes once again? Thanks!

@moiseenkov moiseenkov force-pushed the datafusion_refactor_project_id branch from 685c277 to 8ceda52 Compare October 12, 2023 11:35
@moiseenkov moiseenkov requested a review from eladkal October 12, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants