Skip to content

Conversation

@Taragolis
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis force-pushed the do-not-recommend-mssql branch from c679a22 to 22a86c1 Compare September 14, 2023 15:40
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for vote to finish :)

I belive we will terminate MSSQL for Airflow 2.8.0 cc @potiuk ?

@potiuk
Copy link
Member

potiuk commented Sep 14, 2023

Lets wait for vote to finish :)

I belive we will terminate MSSQL for Airflow 2.8.0 cc @potiuk ?

If somoene implements the removal and migration solution to Postgres- yes. The condition of dropping MSSQL was to get a tool that will help MSSQL users to migrate to Postgres, so we have to implement it.

@Taragolis
Copy link
Contributor Author

Let's explain my motivation for add it now, even if we drop in 2.8.0. User who make chouse MsSQL at 2.7.2 actually make non-obvious selection for Postgres 🤣

@potiuk
Copy link
Member

potiuk commented Sep 14, 2023

Let's explain my motivation for add it now, even if we drop in 2.8.0. User who make chouse MsSQL at 2.7.2 actually make non-obvious selection for Postgres 🤣

Yes. We shoudl definitely add the information now. And also mark it clearly as deprecated for 2.7.2

@potiuk potiuk added this to the Airflow 2.7.2 milestone Sep 14, 2023
@potiuk potiuk merged commit a122b57 into apache:main Sep 14, 2023
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants