Skip to content

Avoid creating unnecessary list when parsing stats datadog tags #33943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uranusjr merged 1 commit into from
Aug 31, 2023
Merged

Avoid creating unnecessary list when parsing stats datadog tags #33943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions airflow/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,10 @@ def __init__(cls, *args, **kwargs) -> None:
@classmethod
def get_constant_tags(cls) -> list[str]:
"""Get constant DataDog tags to add to all stats."""
tags: list[str] = []
tags_in_string = conf.get("metrics", "statsd_datadog_tags", fallback=None)
if tags_in_string is None or tags_in_string == "":
return tags
else:
for key_value in tags_in_string.split(","):
tags.append(key_value)
return tags
if not tags_in_string:
return []
return tags_in_string.split(",")


if TYPE_CHECKING:
Expand Down