Skip to content

Cleanup: remove remnants of 'shutdown' task instance state #33893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 29, 2023
Merged

Cleanup: remove remnants of 'shutdown' task instance state #33893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airflow/www/static/js/cluster-activity/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ const mockHistoricalMetricsData = {
restarting: 0,
running: 0,
scheduled: 0,
shutdown: 0,
skipped: 0,
success: 1634,
up_for_reschedule: 0,
Expand Down
1 change: 0 additions & 1 deletion airflow/www/static/js/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ type TaskState =
| RunState
| "removed"
| "scheduled"
| "shutdown"
| "restarting"
| "up_for_retry"
| "up_for_reschedule"
Expand Down
1 change: 0 additions & 1 deletion docs/apache-airflow/core-concepts/tasks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
* ``shutdown``: The task was externally requested to shut down when it was running
Copy link
Member

@uranusjr uranusjr Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a note be added below this list to mention there used to be a shutdown state but not anymore?

Copy link
Contributor Author

@Bisk1 Bisk1 Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt like it's not useful information because users of new version won't see 'shutdown' state and if someone has older version they should look at relevant, older docs. There probably should be an update in release notes though. But I can modify it if you're sure.

Copy link
Member

@potiuk potiuk Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it in #33746 and it turned out that SHUTDOWN not only has been deeply buried and nearly forgotten but also it has never been working for things like API. So I think I would prefer to pretend it never existed :P

* ``restarting``: The task was externally requested to restart when it was running
* ``failed``: The task had an error during execution and failed to run
* ``skipped``: The task was skipped due to branching, LatestOnly, or similar.
Expand Down
1 change: 0 additions & 1 deletion docs/apache-airflow/howto/customize-ui.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ following steps:
"restarting": "violet",
"running": "#01FF70",
"scheduled": "tan",
"shutdown": "blue",
"skipped": "darkorchid",
"success": "#2ECC40",
"up_for_reschedule": "turquoise",
Expand Down