-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix action logging decorator for un/pausing events #33713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
| params = {k: v for k, v in itertools.chain(request.values.items(), request.view_args.items())} | ||
|
|
||
| if params and "is_paused" in params: | ||
| extra_fields.append(("is_paused", params["is_paused"] == "false")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ping us once you do and we will take a look
closes: #31871
Hey there 👋
Issue
Since logging happens before the action takes place, the
is_pausedquery param was not matching the further transformation that happened onviews.py.Worth noting
is_pausedtofields_skip_loggingbut I decided to do it because it will prevent traversing the list down the line looking for the tuple location.booltype into the correct Python equivalent:False|Truerather than"false"|"true".Happy to discuss and improve it further.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.