Skip to content

Conversation

@alephmelo
Copy link
Contributor

closes: #31871

Hey there 👋

Issue

Since logging happens before the action takes place, the is_paused query param was not matching the further transformation that happened on views.py.

Worth noting

  1. It feels awkward adding is_paused to fields_skip_logging but I decided to do it because it will prevent traversing the list down the line looking for the tuple location.
  2. Now it will properly cast the bool type into the correct Python equivalent: False|True rather than "false"|"true".

Happy to discuss and improve it further.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 25, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 25, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.7.1 milestone Aug 30, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Aug 30, 2023
@eladkal eladkal requested a review from ephraimbuddy August 30, 2023 14:26
params = {k: v for k, v in itertools.chain(request.values.items(), request.view_args.items())}

if params and "is_paused" in params:
extra_fields.append(("is_paused", params["is_paused"] == "false"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Will do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ping us once you do and we will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pause/unpause dag logs wrong event status

3 participants